Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(poweredBy): remove TypeScript extension in import #3530

Merged
merged 2 commits into from
Feb 14, 2019
Merged

fix(poweredBy): remove TypeScript extension in import #3530

merged 2 commits into from
Feb 14, 2019

Conversation

francoischalifour
Copy link
Member

Closes #3528

@francoischalifour francoischalifour requested a review from a team February 14, 2019 08:30
@francoischalifour francoischalifour mentioned this pull request Feb 14, 2019
Closed
@francoischalifour
Copy link
Member Author

Storybook cannot resolve PoweredBy.tsx without the extension:

ERROR in ./src/widgets/powered-by/powered-by.js
Module not found: Error: Can't resolve '../../components/PoweredBy/PoweredBy' in '[...]/instantsearch.js/src/widgets/powered-by'
 @ ./src/widgets/powered-by/powered-by.js 4:0-61 22:33-42
 @ ./src/widgets/index.js
 @ ./src/lib/main.js
 @ ./src/index.js
 @ ./.storybook/decorators.js
 @ ./stories/hierarchical-menu.stories.js
 @ ./stories sync .stories.(js|ts|tsx)$
 @ ./.storybook/config.js

Any clue @algolia/instantsearch-for-websites?

@samouss
Copy link
Contributor

samouss commented Feb 14, 2019 

defaultConfig.resolve.extensions.push('.ts', '.tsx');

https://storybook.js.org/configurations/typescript-config/#setting-up-typescript-to-work-with-storybook

@francoischalifour
Copy link
Member Author

Huh, I missed that part. Thanks!

@algobot
Copy link
Contributor

algobot commented Feb 14, 2019

Deploy preview for instantsearchjs ready!

Built with commit 319956e

https://deploy-preview-3530--instantsearchjs.netlify.com

@francoischalifour francoischalifour merged commit 99ecc0b into develop Feb 14, 2019
@francoischalifour francoischalifour deleted the fix/PoweredBy.tsx-import branch February 14, 2019 12:02
francoischalifour added a commit that referenced this pull request Feb 14, 2019
@francoischalifour
v3.1.1
f429a4a 
* **connectToggleRefinement:** keep user provided, but falsy values ([#3526](#3526)) ([958a151](958a151))
* **poweredBy:** remove TypeScript extension in import ([#3530](#3530)) ([99ecc0b](99ecc0b)), closes [#3528](#3528)
* **release:** update doctoc script ([e07c654](e07c654))
francoischalifour added a commit that referenced this pull request Mar 18, 2019
@francoischalifour
v3.2.1
ea91962 
## [3.2.1](v3.1.0...v3.2.1) (2019-03-18)

### Bug Fixes

* **connectToggleRefinement:** keep user provided, but falsy values ([#3526](#3526)) ([958a151](958a151))
* **instantsearch:** update usage errors ([#3543](#3543)) ([a2a800b](a2a800b))
* **panel:** append panel body as a child element ([#3561](#3561)) ([3de59a3](3de59a3))
* **poweredBy:** remove TypeScript extension in import ([#3530](#3530)) ([99ecc0b](99ecc0b)), closes [#3528](#3528)
* **release:** update doctoc script ([e07c654](e07c654))
* **searchbox:** unmount component on dispose ([#3563](#3563)) ([c3f0435](c3f0435))
* **searchBox:** add reusable SearchBox component ([#3489](#3489)) ([c073a9a](c073a9a))

### Features

* **panel:** implement collapsed feature ([#3575](#3575)) ([e84b02b](e84b02b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@francoischalifour @samouss @algobot @Haroenv